Blaze Sort->MergeJoin reduces key row and column conversion#1078
Merged
Blaze Sort->MergeJoin reduces key row and column conversion#1078
Conversation
eden123456789
changed the title
Modify joiner and implement fix key_has_nulls logic add exclude_time refactor adjust poll_time projected row_null_checker
eden123456789
force-pushed
the
dev-output-key-rows
branch
from
247ac91 to
0886090
Compare
richox
reviewed
Jul 29, 2025
Contributor
richox
left a comment
richox
left a comment
There was a problem hiding this comment.
there are some bugs in row_null_checker, please fix them
| DataType::Float32 => FieldConfig::new_primitive(sort_options, 5), // 1 byte null | ||
| // flag + 4 bytes | ||
| // value | ||
| DataType::Float64 => FieldConfig::new_primitive(sort_options, 9), // 1 byte null |
Contributor
There was a problem hiding this comment.
we should add DataType::Decimal128 as primitive type here
| } | ||
| _ => { | ||
| // For unsupported types, treat as variable length | ||
| FieldConfig::new_variable(sort_options) |
Contributor
There was a problem hiding this comment.
should panic when meeting unsupported types
richox
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1077.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?