Skip to content

Conversation

@lidavidm
Copy link
Member

No description provided.

Comment on lines +1295 to +1394
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly, but not fully, backwards compatible (something like ds.ReadOptions(use_buffered_stream=True) no longer works) - is that an issue?

@github-actions
Copy link

@lidavidm
Copy link
Member Author

(I am working on the CI failures. It appears to only occur in release mode under Windows.)

@lidavidm lidavidm marked this pull request as draft March 24, 2021 18:57
Comment on lines +64 to +73
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note I didn't bother exposing this to Python/R since the IPC options in general aren't really exposed.

@lidavidm lidavidm marked this pull request as ready for review March 25, 2021 13:26
@lidavidm lidavidm requested a review from bkietz March 25, 2021 13:26
@lidavidm
Copy link
Member Author

@ursabot please benchmark

@ursabot
Copy link

ursabot commented Mar 25, 2021

Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with me on the R side, looks like effectively no change for the usual R use case.

@ursabot
Copy link

ursabot commented Mar 25, 2021

@ursabot
Copy link

ursabot commented Mar 25, 2021

@ursabot
Copy link

ursabot commented Mar 25, 2021

@lidavidm lidavidm requested a review from bkietz March 26, 2021 19:38
@ursabot
Copy link

ursabot commented Apr 7, 2021

Copy link
Member

@bkietz bkietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants