-
Notifications
You must be signed in to change notification settings - Fork 3.9k
ARROW-11972: [C++][R][Python][Dataset] Extract IPC/Parquet fragment scan options #9790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
python/pyarrow/_dataset.pyx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly, but not fully, backwards compatible (something like ds.ReadOptions(use_buffered_stream=True) no longer works) - is that an issue?
|
(I am working on the CI failures. It appears to only occur in release mode under Windows.) |
cpp/src/arrow/dataset/file_ipc.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note I didn't bother exposing this to Python/R since the IPC options in general aren't really exposed.
|
@ursabot please benchmark |
|
Benchmark runs are scheduled for baseline = 9262a5d and contender = 01895d4cb3b4c8b47b744cc0339a6940a1f5cd5b. Results will be available as each benchmark for each run completes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok with me on the R side, looks like effectively no change for the usual R use case.
|
Benchmark runs are scheduled for baseline = 7692461 and contender = 2b1a6a6ec9e1e8cf92bb490e6a93ede3300e21c7. Results will be available as each benchmark for each run completes: |
|
Benchmark runs are scheduled for baseline = 7692461 and contender = 1396d4699a07fe1449b57d91c80d6dd8cd67ac34. Results will be available as each benchmark for each run completes: |
|
Benchmark runs are scheduled for baseline = 7692461 and contender = fbdf30f4856b99137dfb768fa4173e0a962ef250. Results will be available as each benchmark for each run completes: |
|
Benchmark runs are scheduled for baseline = d95c72f and contender = ebc7c60. Results will be available as each benchmark for each run completes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
No description provided.