Skip to content

Conversation

@jorgecarleitao
Copy link
Member

No description provided.

@jorgecarleitao jorgecarleitao changed the title [MINOR] [Rust] [Parquet] Cleanup clippy ARROW-12047: [Rust] [Parquet] Cleanup clippy Mar 22, 2021
@github-actions
Copy link

@apache apache deleted a comment from github-actions bot Mar 23, 2021
@codecov-io
Copy link

Codecov Report

Merging #9775 (cd369c9) into master (29feea0) will decrease coverage by 0.32%.
The diff coverage is 81.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9775      +/-   ##
==========================================
- Coverage   82.59%   82.27%   -0.33%     
==========================================
  Files         248      249       +1     
  Lines       58294    58359      +65     
==========================================
- Hits        48149    48013     -136     
- Misses      10145    10346     +201     
Impacted Files Coverage Δ
rust/arrow/src/compute/kernels/take.rs 96.06% <ø> (-0.01%) ⬇️
rust/arrow/src/compute/kernels/window.rs 100.00% <ø> (ø)
rust/arrow/src/compute/kernels/zip.rs 82.14% <ø> (ø)
rust/arrow/src/compute/util.rs 98.92% <ø> (ø)
rust/arrow/src/ffi.rs 76.22% <ø> (ø)
rust/arrow/src/ipc/reader.rs 84.36% <ø> (ø)
rust/arrow/src/ipc/writer.rs 87.44% <ø> (+0.21%) ⬆️
rust/arrow/src/json/reader.rs 83.45% <ø> (-0.06%) ⬇️
rust/arrow/src/json/writer.rs 87.91% <ø> (ø)
rust/arrow/src/record_batch.rs 83.70% <ø> (ø)
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eebf64b...cd369c9. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement to me. Thanks @jorgecarleitao

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb closed this in fe6ef70 Mar 24, 2021
@jorgecarleitao jorgecarleitao deleted the clippy_clean branch March 24, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants