ARROW-12012: [Java][JDBC] Fix BinaryConsumer reallocation #9744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liyafan82 or @tianchen92 do you have time to review? |
@zxf Thanks for the patch. I will take a look. |
liyafan82
reviewed
Mar 19, 2021
java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/consumer/BinaryConsumer.java
Outdated
Show resolved
Hide resolved
liyafan82
reviewed
Mar 19, 2021
java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/consumer/BinaryConsumer.java
Outdated
Show resolved
Hide resolved
liyafan82
reviewed
Mar 19, 2021
java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/consumer/BinaryConsumerTest.java
Outdated
Show resolved
Hide resolved
liyafan82
reviewed
Mar 19, 2021
java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/consumer/BinaryConsumerTest.java
Show resolved
Hide resolved
liyafan82
reviewed
Mar 19, 2021
java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/consumer/BinaryConsumerTest.java
Outdated
Show resolved
Hide resolved
liyafan82
reviewed
Mar 19, 2021
java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/consumer/BinaryConsumerTest.java
Show resolved
Hide resolved
|
Rerunning integration tests. The failure seems unrelated. |
|
Mostly look good. Thank you @zxf |
|
+1. Thanks @zxf |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
[ARROW-12012](https://issues.apache.org/jira/browse/ARROW-12012) An exception will be thrown when BinaryConsumer consumes a large amount or a lot of data. Closes apache#9744 from zxf/fix/jdbc-binary-consumer Authored-by: Felix Zhu <felix.zhu@netis.com.cn> Signed-off-by: liyafan82 <fan_li_ya@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARROW-12012
An exception will be thrown when BinaryConsumer consumes a large amount or a lot of data.