ARROW-10463: [R] Better messaging for currently unsupported CSV options in open_dataset #9143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nealrichardson let me know if you'd also like to me to add text in these two places in the |
You could, but IMO a better (though not mutually exclusive) solution would be to use the error message to tell you that more clearly #9143 (comment). I don't assume people read help pages, at least not that closely. |
|
@nealrichardson I believe 205d1e7 resolves the issues you raised here |
nealrichardson
requested changes
Jan 11, 2021
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
nealrichardson
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves messaging for currently unsupported readr parse options and improves handling in related cases such as ambiguous partial argument names and invalid combinations of Arrow and readr options