-
Couldn't load subscription status.
- Fork 3.9k
ARROW-1243: [JAVA] update all libs to latest versions #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Most of this looks good. Let's evaluate upgrading Guava separately (not sure what it buys us and they are horrible at maintaining compatibility between versions). Can you back that out? |
|
guava upgrade now backed out as requested |
|
The following table shows every dependency in the tree (including all child dependencies). For each, it shows the current version and date of that version, together with the date and version number of the latest version, and the number of releases between our version and the latest version.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern: doesn't lilith v8.x support java 7? Don't want to accidentally remove java 7 support. Otherwise, looks good
java/pom.xml
Outdated
| <groupId>de.huxhorn.lilith</groupId> | ||
| <artifactId>de.huxhorn.lilith.logback.appender.multiplex-classic</artifactId> | ||
| <version>0.9.44</version> | ||
| <version>8.1.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this support java 7?
|
@mattdarwin as soon as we rebase and address the java7 question I can merge this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
|
Well spotted - Lilith 8 does indeed remove support for Java 7. I've rolled that change back. |
|
@jacques-n @siddharthteotia there were some bugs in these dependency upgrade patches fixed in #957 and #960. Could someone comment whether the 0.6.0 RC is still good or whether we need to make a new RC? |
NB this commit excludes Jackson and logback upgrades, since they are dealt with in 871 and 872 Author: Matt Darwin <(none)> Author: Matt Darwin <matt.darwin@oracle.com> Author: Matt <mattdarwin@yahoo.co.uk> Closes apache#873 from mattdarwin/upgrade-libs and squashes the following commits: 9b51f46 [Matt Darwin] Merge branch 'master' into upgrade-libs 284a4ce [Matt Darwin] Merge branch 'master' of https://github.com/apache/arrow 79550b1 [Matt Darwin] rolling back lilith to 0.9.44 since 8 doesn't support java 7 c63eef6 [Matt Darwin] Merge branch 'master' into upgrade-libs bc3b6a0 [Matt] Merge pull request #1 from apache/master 8599ba0 [Matt Darwin] backing out guava upgrade 80d81e6 [Matt Darwin] downgrading guava to 20 for java 7 compatibility 806f348 [Matt Darwin] Merge branch 'master' into upgrade-libs 8aafb7e [Matt Darwin] correcting indentation in BaseValueVector 94c1469 [Matt Darwin] upgrading netty to 4.0.49 cff5596 [Matt Darwin] reverting to netty 4.0.41.Final 568737d [Matt Darwin] switching to Collections from Guava for empty iterator c194e48 [Matt Darwin] upgraded hppc to 0.7.2 38be468 [Matt Darwin] upgrading libs except jackson and logback
NB this commit excludes Jackson and logback upgrades, since they are dealt with in 871 and 872