Skip to content

Conversation

@mattdarwin
Copy link

NB this commit excludes Jackson and logback upgrades, since they are dealt with in 871 and 872

@mattdarwin mattdarwin changed the title ARROW-1242: [JAVA] update all libs to latest versions ARROW-1243: [JAVA] update all libs to latest versions Jul 20, 2017
@jacques-n
Copy link
Contributor

Most of this looks good. Let's evaluate upgrading Guava separately (not sure what it buys us and they are horrible at maintaining compatibility between versions). Can you back that out?

@mattdarwin
Copy link
Author

guava upgrade now backed out as requested

@mattdarwin
Copy link
Author

mattdarwin commented Aug 1, 2017

The following table shows every dependency in the tree (including all child dependencies). For each, it shows the current version and date of that version, together with the date and version number of the latest version, and the number of releases between our version and the latest version.

groupId artifactId current version date latest version date number of newer versions
ch.qos.logback logback-classic 1.0.13 10-May-13 1.2.3 31-Mar-17 16
ch.qos.logback logback-core 1.0.13 10-May-13 1.2.3 31-Mar-17 16
com.carrotsearch hppc 0.7.1 07-May-15 0.7.2 25-Oct-16 1
com.fasterxml.jackson.core jackson-annotations 2.7.1 02-Feb-16 2.9.0 30-Jul-17 25
com.fasterxml.jackson.core jackson-core 2.7.1 02-Feb-16 2.9.0 30-Jul-17 25
com.fasterxml.jackson.core jackson-databind 2.7.1 02-Feb-16 2.9.0 30-Jul-17 29
com.google.code.findbugs jsr305 3.0.1 09-Oct-15 3.0.2 31-Mar-17 1
com.google.guava guava 18 25-Aug-14 22.0 22-May-17 5
com.vlkan flatbuffers 1.2.0-3f79e055 09-Nov-15 1.2.0-3f79e055 09-Nov-15 0
commons-cli commons-cli 1.2 19-Mar-09 1.4 09-Mar-17 3
commons-codec commons-codec 1.10 06-Nov-14 1.10 06-Nov-14 0
io.netty netty-buffer 4.0.41.Final 29-Aug-16 4.1.13.Final 06-Jul-17 16
io.netty netty-codec 4.0.41.Final 29-Aug-16 4.1.13.Final 06-Jul-17 16
io.netty netty-common 4.0.41.Final 29-Aug-16 4.1.13.Final 06-Jul-17 16
io.netty netty-handler 4.0.41.Final 29-Aug-16 4.1.13.Final 06-Jul-17 16
io.netty netty-transport 4.0.41.Final 29-Aug-16 4.1.13.Final 06-Jul-17 16
joda-time joda-time 2.9 24-Oct-15 2.9.9 23-Mar-17 9
org.apache.commons commons-lang3 3.4 03-Apr-15 3.6 09-Jun-17 2
org.slf4j slf4j-api 1.7.6 05-Feb-14 1.7.25 16-Mar-17 18

Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern: doesn't lilith v8.x support java 7? Don't want to accidentally remove java 7 support. Otherwise, looks good

java/pom.xml Outdated
<groupId>de.huxhorn.lilith</groupId>
<artifactId>de.huxhorn.lilith.logback.appender.multiplex-classic</artifactId>
<version>0.9.44</version>
<version>8.1.1</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this support java 7?

@wesm
Copy link
Member

wesm commented Aug 8, 2017

@mattdarwin as soon as we rebase and address the java7 question I can merge this

Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mattdarwin
Copy link
Author

Well spotted - Lilith 8 does indeed remove support for Java 7. I've rolled that change back.

@asfgit asfgit closed this in 7fdbcc6 Aug 9, 2017
@wesm
Copy link
Member

wesm commented Aug 11, 2017

@jacques-n @siddharthteotia there were some bugs in these dependency upgrade patches fixed in #957 and #960. Could someone comment whether the 0.6.0 RC is still good or whether we need to make a new RC?

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
NB this commit excludes Jackson and logback upgrades, since they are dealt with in 871 and 872

Author: Matt Darwin <(none)>
Author: Matt Darwin <matt.darwin@oracle.com>
Author: Matt <mattdarwin@yahoo.co.uk>

Closes apache#873 from mattdarwin/upgrade-libs and squashes the following commits:

9b51f46 [Matt Darwin] Merge branch 'master' into upgrade-libs
284a4ce [Matt Darwin] Merge branch 'master' of https://github.com/apache/arrow
79550b1 [Matt Darwin] rolling back lilith to 0.9.44 since 8 doesn't support java 7
c63eef6 [Matt Darwin] Merge branch 'master' into upgrade-libs
bc3b6a0 [Matt] Merge pull request #1 from apache/master
8599ba0 [Matt Darwin] backing out guava upgrade
80d81e6 [Matt Darwin] downgrading guava to 20 for java 7 compatibility
806f348 [Matt Darwin] Merge branch 'master' into upgrade-libs
8aafb7e [Matt Darwin] correcting indentation in BaseValueVector
94c1469 [Matt Darwin] upgrading netty to 4.0.49
cff5596 [Matt Darwin] reverting to netty 4.0.41.Final
568737d [Matt Darwin] switching to Collections from Guava for empty iterator
c194e48 [Matt Darwin] upgraded hppc to 0.7.2
38be468 [Matt Darwin] upgrading libs except jackson and logback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants