Skip to content

ARROW-7766: [Python][Packaging] Windows py38 wheels are built with wrong ABI tag #6353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ARROW-7766: [Python][Packaging] Windows py38 wheels are built with wrong ABI tag #6353

wants to merge 1 commit into from

Conversation

@nealrichardson
Copy link
Member

@nealrichardson nealrichardson commented Feb 4, 2020

This is fixed in the latest release of wheel but we were pinning to an old version

@nealrichardson
Copy link
Member Author

nealrichardson commented Feb 4, 2020

@ursabot crossbow submit -g wheel

@kszucs
Copy link
Member

kszucs commented Feb 4, 2020

AMD64 Conda Crossbow Submit (#89258) builder has been succeeded.

Revision: e3a865b

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-486

Task Status
wheel-manylinux1-cp27m Azure
wheel-manylinux1-cp27mu Azure
wheel-manylinux1-cp35m Azure
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux2010-cp27m Azure
wheel-manylinux2010-cp27mu Azure
wheel-manylinux2010-cp35m Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2014-cp35m Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-osx-cp27m TravisCI
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-osx-cp38 TravisCI
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor
wheel-win-cp38 Appveyor

@github-actions
Copy link

github-actions bot commented Feb 4, 2020

https://issues.apache.org/jira/browse/ARROW-7766

@nealrichardson
Copy link
Member Author

nealrichardson commented Feb 4, 2020

Still waiting on the builds to finish, but it seems at least that auditwheel is no longer broken.

@nealrichardson
Copy link
Member Author

nealrichardson commented Feb 4, 2020

Windows py38 wheel has the correct file path now: https://ci.appveyor.com/project/Ursa-Labs/crossbow/builds/30569542#L3198

Also, the warning on master about WITH_PYMALLOC and possible ABI issues (cf. https://ci.appveyor.com/project/Ursa-Labs/crossbow/builds/30556466?fullLog=true#L3078) is no longer present.

The two manylinux failures are timeouts from quay.io in downloading the manylinux docker image.

@wesm PTAL

xhochy
xhochy approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@kszucs
Copy link
Member

kszucs commented Feb 4, 2020

@nealrichardson I've restarted the failing ones.

So I can cherry-pick this change to another branch, then rebuild the py38 wheel for windows. @kou can we re-upload a new wheel for bintray?

@wesm
Copy link
Member

wesm commented Feb 5, 2020

I think it's fine if we manually upload a fixed 0.16.0 wheel to PyPI

wesm
wesm approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in 67e34c5 Feb 5, 2020
@kou
Copy link
Member

kou commented Feb 5, 2020

Yes. We can re-upload.

@kszucs
Copy link
Member

kszucs commented Feb 5, 2020

Thanks! Re-built and re-uploaded the wheels.

@nealrichardson nealrichardson deleted the fix-win-38-wheels branch February 6, 2020 22:44
kszucs pushed a commit that referenced this pull request Feb 7, 2020
@nealrichardson @kszucs
ARROW-7766: [Python][Packaging] Windows py38 wheels are built with wr…
e4d6bd8 
…ong ABI tag

This is fixed in the latest release of `wheel` but we were pinning to an old version

Closes #6353 from nealrichardson/fix-win-38-wheels and squashes the following commits:

e3a865b <Neal Richardson> Remove wheel pin in requirements-wheel.txt

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Wes McKinney <wesm+git@apache.org>
@asfimport asfimport mentioned this pull request Feb 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhochy xhochy xhochy approved these changes

@wesm wesm wesm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nealrichardson @kszucs @wesm @kou @xhochy