Skip to content

ARROW-6671: [C++][Python] Use more consistent names for sparse tensor items #5605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ARROW-6671: [C++][Python] Use more consistent names for sparse tensor items #5605

wants to merge 1 commit into from

Conversation

@mrkn
Copy link
Member

@mrkn mrkn commented Oct 8, 2019

No description provided.

@mrkn
Copy link
Member Author

mrkn commented Oct 8, 2019

This pull-request renames the following names:

  • SparseTensorCOO → SparseCOOTensor
  • SparseTensorCSR → SparseCSRMatrix
  • sparse_tensor_coo → sparse_coo_tensor
  • sparse_tensor_csr → sparse_csr_matrix

And, this removes SparseMatrixCSR symbol.

@github-actions
Copy link

github-actions bot commented Oct 8, 2019

https://issues.apache.org/jira/browse/ARROW-6671

@mrkn
Copy link
Member Author

mrkn commented Oct 8, 2019

This pull-request will break #4990.

@pitrou
Copy link
Member

pitrou commented Oct 8, 2019

@wesm

@pitrou
Copy link
Member

pitrou commented Oct 16, 2019

Rebased.

pitrou
pitrou approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Will merge once green.

@rok rok mentioned this pull request Oct 16, 2019
Closed
@pitrou pitrou closed this in edae4a1 Oct 17, 2019
@rok rok mentioned this pull request Oct 17, 2019
Closed
@mrkn mrkn deleted the ARROW-6671 branch November 14, 2019 06:58
@asfimport asfimport mentioned this pull request Oct 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrkn @pitrou