Skip to content

ARROW-6266: [Java] Resolve the ambiguous method overload in RangeEqualsVisitor #5100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ARROW-6266: [Java] Resolve the ambiguous method overload in RangeEqualsVisitor #5100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7ed538
[ARROW-6266][Java] Resolve the ambiguous method overload in RangeEqua…
liyafan82 Aug 16, 2019
6b5e5c5
[ARROW-6266][Java] Remove the general visit mothod
liyafan82 Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/vector/src/main/java/org/apache/arrow/vector/ExtensionTypeVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,6 @@ public BufferAllocator getAllocator() {

@Override
public boolean accept(RangeEqualsVisitor visitor) {
return visitor.visit(getUnderlyingVector());
return getUnderlyingVector().accept(visitor);
}
}
4 changes: 0 additions & 4 deletions java/vector/src/main/java/org/apache/arrow/vector/compare/RangeEqualsVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,6 @@ public boolean visit(ZeroVector left) {
return validate(left);
}

public boolean visit(ValueVector left) {
throw new UnsupportedOperationException();
}

protected boolean compareValueVector(ValueVector left, ValueVector right) {
if (!typeCheckNeeded) {
return true;
Expand Down