ARROW-6264: [Java] There is no need to consider byte order in ArrowBufHasher #5098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pravindra
approved these changes
Aug 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #5098 +/- ##
==========================================
+ Coverage 87.51% 89.72% +2.2%
==========================================
Files 912 674 -238
Lines 139034 100918 -38116
==========================================
- Hits 121679 90550 -31129
+ Misses 17003 10368 -6635
+ Partials 352 0 -352
Continue to review full report at Codecov.
|
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…fHasher According to the discussion in apache#5063 (comment), Arrow has a mechanism to make sure the data is stored in little-endian, so there is no need to check byte order. Closes apache#5098 from liyafan82/fly_0816_order and squashes the following commits: 538ce59 <liyafan82> ARROW-6264 There is no need to consider byte order in ArrowBufHasher Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Pindikura Ravindra <ravindra@dremio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the discussion in #5063 (comment), Arrow has a mechanism to make sure the data is stored in little-endian, so there is no need to check byte order.