ARROW-6211: [Java] Remove dependency on RangeEqualsVisitor from ValueVector interface #5091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @pravindra |
pravindra
reviewed
Aug 16, 2019
java/vector/src/main/java/org/apache/arrow/vector/compare/RangeEqualsVisitor.java
Outdated
Show resolved
Hide resolved
tianchen92
force-pushed
the
ARROW-6211
branch
2 times, most recently
from
e8af793 to
bcf8a01
Compare
Codecov Report
@@ Coverage Diff @@
## master #5091 +/- ##
==========================================
+ Coverage 87.64% 89.72% +2.08%
==========================================
Files 1014 674 -340
Lines 145922 101357 -44565
Branches 1437 0 -1437
==========================================
- Hits 127887 90942 -36945
+ Misses 17673 10415 -7258
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
pravindra
approved these changes
Aug 19, 2019
|
thanks for the change, @tianchen92 |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…Vector interface Related to [ARROW-6211](https://issues.apache.org/jira/browse/ARROW-6211). This is a follow-up from apache#4933 public interface VectorVisitor<OUT, IN, EX extends Exception> {..} n ValueVector : public <OUT, IN, EX extends Exception> OUT accept(VectorVisitor<OUT, IN, EX> visitor, IN value) throws EX; Closes apache#5091 from tianchen92/ARROW-6211 and squashes the following commits: 15a5231 <tianchen> fix bce258e <tianchen> add equals in RangeEqualsVisitor dbaa81f <tianchen> ARROW-6211: Remove dependency on RangeEqualsVisitor from ValueVector interface Authored-by: tianchen <niki.lj@alibaba-inc.com> Signed-off-by: Pindikura Ravindra <ravindra@dremio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ARROW-6211.
This is a follow-up from #4933
public interface VectorVisitor<OUT, IN, EX extends Exception> {..}
n ValueVector :
public <OUT, IN, EX extends Exception> OUT accept(VectorVisitor<OUT, IN, EX> visitor, IN value) throws EX;