Skip to content

Conversation

@wesm
Copy link
Member

@wesm wesm commented Aug 14, 2019

For example:

export ARROW_R_CXXFLAGS="-fno-omit-frame-pointer"

(this flag is needed to record performance data on Linux with perf)

I also amended the README.Rmd to say to use $R_LD_LIBRARY_PATH instead of $LD_LIBRARY_PATH for custom install location

Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of notes but otherwise LGTM

r/README.md Outdated

``` r
library(arrow)
#>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this added comment output? It's not helpful IMO. (If you regenerate this with make doc, it doesn't appear because the arrow package is already loaded before this code chunk is evaluated.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, will do

r/configure Outdated
PKG_CFLAGS="$PKG_CFLAGS -D_GLIBCXX_USE_CXX11_ABI=0"
fi

if [ "$ARROW_R_CXXFLAGS" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note to the README about this feature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@codecov-io
Copy link

Codecov Report

Merging #5088 into master will decrease coverage by 12.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5088       +/-   ##
===========================================
- Coverage   87.63%   75.25%   -12.38%     
===========================================
  Files        1013       57      -956     
  Lines      144891     3617   -141274     
  Branches     1418        0     -1418     
===========================================
- Hits       126971     2722   -124249     
+ Misses      17558      895    -16663     
+ Partials      362        0      -362
Impacted Files Coverage Δ
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
rust/parquet/src/arrow/converter.rs
cpp/src/arrow/python/io.cc
... and 946 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef7e80...e25de5e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants