-
Notifications
You must be signed in to change notification settings - Fork 3.9k
ARROW-6237: [R] Allow compilation flags to be passed for R package with ARROW_R_CXXFLAGS #5088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nealrichardson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of notes but otherwise LGTM
r/README.md
Outdated
|
|
||
| ``` r | ||
| library(arrow) | ||
| #> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this added comment output? It's not helpful IMO. (If you regenerate this with make doc, it doesn't appear because the arrow package is already loaded before this code chunk is evaluated.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, will do
r/configure
Outdated
| PKG_CFLAGS="$PKG_CFLAGS -D_GLIBCXX_USE_CXX11_ABI=0" | ||
| fi | ||
|
|
||
| if [ "$ARROW_R_CXXFLAGS" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a note to the README about this feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
nealrichardson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
Codecov Report
@@ Coverage Diff @@
## master #5088 +/- ##
===========================================
- Coverage 87.63% 75.25% -12.38%
===========================================
Files 1013 57 -956
Lines 144891 3617 -141274
Branches 1418 0 -1418
===========================================
- Hits 126971 2722 -124249
+ Misses 17558 895 -16663
+ Partials 362 0 -362Continue to review full report at Codecov.
|
For example:
(this flag is needed to record performance data on Linux with
perf)I also amended the README.Rmd to say to use
$R_LD_LIBRARY_PATHinstead of$LD_LIBRARY_PATHfor custom install location