Skip to content

GH-50901: [C++] Replace RapidJSON with simdjson in tensor extension types - #50874

Open
Reranko05 wants to merge 4 commits into
apache:mainfrom
Reranko05:gh-35460-extension
Open

GH-50901: [C++] Replace RapidJSON with simdjson in tensor extension types#50874
Reranko05 wants to merge 4 commits into
apache:mainfrom
Reranko05:gh-35460-extension

Conversation

@Reranko05

@Reranko05 Reranko05 commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Rationale for this change

This PR continues the simdjson migration by replacing RapidJSON usage in the FixedShapeTensorType and VariableShapeTensorType extension types with the existing simdjson helpers and On-Demand API.

Changes

  • Replace RapidJSON parsing in FixedShapeTensorType::Deserialize with simdjson.
  • Replace RapidJSON parsing in VariableShapeTensorType::Deserialize with simdjson.
  • Use the existing simdjson helpers for JSON type and result handling.
  • Remove the obsolete RapidJSON-specific JsonTypeName helper from the tensor extension utilities.
  • Remove the remaining RapidJSON includes from the tensor extension utilities.
  • Update deserialization tests to match simdjson JSON type names.

Fixes: #50901

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format.

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

After updating the title, you can mark the pull request as ready for review.

See also:

@Reranko05 Reranko05 added the CI: Extra: C++ Run extra C++ CI label Aug 15, 2026
@Reranko05 Reranko05 changed the title [WIP] GH-50873: [C++] Migrate FixedShapeTensorType deserialization to simdjson GH-50901: [C++] Replace RapidJSON with simdjson in tensor extension types Aug 18, 2026
@Reranko05
Reranko05 marked this pull request as ready for review August 18, 2026 10:57
@Reranko05
Reranko05 requested a review from pitrou as a code owner August 18, 2026 10:57
Copilot AI lite review requested due to automatic review settings August 18, 2026 10:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Reranko05
Reranko05 requested review from kou and rok August 18, 2026 10:57
Copilot AI review requested due to automatic review settings August 18, 2026 18:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Comment thread cpp/src/arrow/extension/fixed_shape_tensor.cc Outdated
@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Aug 18, 2026
Copilot AI review requested due to automatic review settings August 19, 2026 07:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 19, 2026
@Reranko05
Reranko05 requested a review from kou August 19, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting change review Awaiting change review CI: Extra: C++ Run extra C++ CI Component: C++

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] Replace RapidJSON with simdjson in tensor extension types

3 participants