ARROW-6215: [Java] Fix case when ZeroVector is compared against other vector types #5070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @tianchen92 |
BryanCutler
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5070 +/- ##
==========================================
+ Coverage 87.6% 89.71% +2.1%
==========================================
Files 1009 670 -339
Lines 144082 99567 -44515
Branches 1418 0 -1418
==========================================
- Hits 126227 89327 -36900
+ Misses 17493 10240 -7253
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
Member
Author
|
merged to master |
BryanCutler
deleted the
java-RangeEqualsVisitor-fix-ZeroVector-ARROW-6215
branch
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
… vector types This fixes a bug that when a ZeroVector is compared with a vector of any other type, it always returns true. Instead of hard-coding a return value of `true` in `ZeroVector.accept`, the `RangeEqualsVisitor` is used to compare the vector types. Closes apache#5070 from BryanCutler/java-RangeEqualsVisitor-fix-ZeroVector-ARROW-6215 and squashes the following commits: 7ad41be <Bryan Cutler> Fix case when ZeroVector is compared against other vector types Authored-by: Bryan Cutler <cutlerb@gmail.com> Signed-off-by: Bryan Cutler <cutlerb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that when a ZeroVector is compared with a vector of any other type, it always returns true. Instead of hard-coding a return value of
trueinZeroVector.accept, theRangeEqualsVisitoris used to compare the vector types.