Skip to content

ARROW-6142: [R] Install instructions on linux could be clearer #5027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

ARROW-6142: [R] Install instructions on linux could be clearer #5027

wants to merge 5 commits into from

Conversation

@nealrichardson
Copy link
Member

@nealrichardson nealrichardson commented Aug 6, 2019 •
edited
Loading

This updates the language in install_arrow() to follow the README revision that will land in https://github.com/apache/arrow/pull/4948/files#diff-563b2cb2c8c2d51b2ff6b177e2d84286R33.

The Jira ticket requested three things; this is #2 in the list. On #1, I defer to the C++ installation docs, which are already included in the install_arrow message, rather than duplicating content here. #3 is out of scope.

@karldw
Copy link
Contributor

karldw commented Aug 7, 2019

Thank you!

Other users who have the same question I asked in #1: the required packages to have a working R installation are libarrow-dev and libparquet-dev, but not any of the others.

kou
kou reviewed Aug 7, 2019
View reviewed changes
r/R/install-arrow.R Outdated
"<https://arrow.apache.org/install/>",
"for how to install the C++ package from a PPA."
"to find pre-compiled binary packages for some common Linux distributions,",
"such as Debian, Ubuntu, CentOS, and Fedora."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't provide packages for Fedora yet...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I was blindly following #4948 (comment). Will revise.

@nealrichardson
Copy link
Member Author

Thanks for the clarification @karldw, I misunderstood before. Will add reference to those two packages.

@nealrichardson
Copy link
Member Author

Revised, PTAL

kou
kou reviewed Aug 7, 2019
View reviewed changes
r/R/install-arrow.R Outdated
"for how to install the C++ package from a PPA."
"to find pre-compiled binary packages for some common Linux distributions,",
"including Debian, Ubuntu, and CentOS. You'll need to install 'libarrow-dev'",
"and 'libparquet-dev'."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libarrow-dev and libparquet-dev are right package names for Debian and Ubuntu.
But arrow-devel and parquet-devel are right package names for CentOS.

BTW, we can install only libparquet-dev or parquet-devel because libarrow-dev and arrow-devel are automatically installed as dependency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, revised accordingly.

kou
kou approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
We can merge this with a small fix. ("arrow" -> "Arrow")

Thanks!

r/R/install-arrow.R Outdated
"to find pre-compiled binary packages for some common Linux distributions,",
"including Debian, Ubuntu, and CentOS. You'll need to install",
"'libparquet-dev' on Debian and Ubuntu, or 'parquet-devel' on CentOS. This",
"will also automatically install the arrow C++ library as a dependency."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use "Arrow" instead of "arrow"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kou
Copy link
Member

kou commented Aug 8, 2019

I'll merge this when CI is green.

@nealrichardson
Copy link
Member Author

Here's my fork, which I'm guessing will finish faster: https://travis-ci.org/nealrichardson/arrow/jobs/569137979

@codecov-io
Copy link

Codecov Report

Merging #5027 into master will decrease coverage by 12.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #5027       +/-   ##
==========================================
- Coverage   87.33%   75.3%   -12.03%     
==========================================
  Files         895      57      -838     
  Lines      119946    3620   -116326     
  Branches     1418       0     -1418     
==========================================
- Hits       104751    2726   -102025     
+ Misses      14833     894    -13939     
+ Partials      362       0      -362
Impacted Files Coverage Δ
r/R/install-arrow.R 100% <ø> (ø) ⬆️
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
go/arrow/memory/memory_avx2_amd64.go
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
cpp/src/parquet/column_scanner.cc
...p/src/gandiva/precompiled/epoch_time_point_test.cc
... and 829 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cfa7b3...80b142e. Read the comment docs.

@kou
Copy link
Member

kou commented Aug 8, 2019

Thanks. CI is green. I'll merge this.

@kou kou closed this in 908b058 Aug 8, 2019
nealrichardson added a commit to nealrichardson/arrow that referenced this pull request Aug 8, 2019
@nealrichardson
ARROW-6142: [R] Install instructions on linux could be clearer
d0711ab 
This updates the language in `install_arrow()` to follow the README revision that will land in https://github.com/apache/arrow/pull/4948/files#diff-563b2cb2c8c2d51b2ff6b177e2d84286R33.

The [Jira ticket](https://issues.apache.org/jira/browse/ARROW-6142) requested three things; this is `#2` in the list. On `#1`, I defer to the C++ installation docs, which are already included in the install_arrow message, rather than duplicating content here. `#3` is out of scope.

Closes apache#5027 from nealrichardson/no-ppa and squashes the following commits:

80b142e <Neal Richardson> s/arrow/Arrow/
44c9659 <Neal Richardson> Tweak language again
36cfe28 <Neal Richardson> Further linux install revisions
79bd7e0 <Neal Richardson> One more PPurge
63f75bd <Neal Richardson> Revise install_arrow instructions for Linux

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@asfimport asfimport mentioned this pull request Aug 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nealrichardson @karldw @kou @codecov-io