ARROW-6093: [Java] reduce branches in algo for first match in VectorRangeSearcher #5011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5011 +/- ##
==========================================
+ Coverage 87.57% 89.67% +2.1%
==========================================
Files 1008 670 -338
Lines 143790 99342 -44448
Branches 1418 0 -1418
==========================================
- Hits 125924 89088 -36836
+ Misses 17504 10254 -7250
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
emkornfield
reviewed
Aug 9, 2019
Contributor
Author
There was a problem hiding this comment.
nice catch. thank you so much.
Contributor
|
Small nit, otherwise LGTM. |
liyafan82
force-pushed
the
fly_0805_range
branch
from
fb61c46 to
f47a2e7
Compare
Contributor
|
+1, LGTM |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…angeSearcher This is a follow up Jira for the improvement suggested by Francois Saint-Jacques in the PR for apache#4925 After careful analysis and proof, I found @fsaintjacques 's proposal really works. The idea behind the algorithm is tricky. This PR is the implementation based on @fsaintjacques 's proposal. The benefit of this implementation: 1. the code is much clearer 2. there is fewer branches, which is beneficial for performance. The drawback of this implementation: 1. there can be dumb iterations of the main loop. That is, the while loop may run a few more times after the "solution" is found, just to wait for the loop termination condition is satisfied. However, the time complexity of the algorithm is still O(logn), and the number of dumb iterations can not be large. Closes apache#5011 from liyafan82/fly_0805_range and squashes the following commits: f47a2e7 <liyafan82> reduce branches in algo for first match in VectorRangeSearcher Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up Jira for the improvement suggested by Francois Saint-Jacques in the PR for
#4925
After careful analysis and proof, I found @fsaintjacques 's proposal really works. The idea behind the algorithm is tricky. This PR is the implementation based on @fsaintjacques 's proposal.
The benefit of this implementation:
The drawback of this implementation:
However, the time complexity of the algorithm is still O(logn), and the number of dumb iterations can not be large.