ARROW-3204: [R] Enable R package to be made available on CRAN

[nealrichardson]

With these changes, we've got 0.14.0 passing the automated checks and we're pending human review. There will probably be further changes requested, which we'll collect here.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@03dc59d). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #4908   +/-   ##
=========================================
  Coverage          ?   87.57%           
=========================================
  Files             ?     1005           
  Lines             ?   143539           
  Branches          ?     1418           
=========================================
  Hits              ?   125698           
  Misses            ?    17479           
  Partials          ?      362

Impacted Files	Coverage Δ
r/R/feather.R	63.63% <ø> (ø)
r/R/csv.R	97.8% <ø> (ø)
r/R/json.R	93.75% <ø> (ø)
r/R/parquet.R	72% <ø> (ø)
r/R/install-arrow.R	100% <100%> (ø)
r/R/Field.R	83.33% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03dc59d...9a71289. Read the comment docs.

[nealrichardson]

@wesm is this legit to do? See https://github.com/apache/arrow/pull/4908/files#diff-3d1942ed064c42a43c8aef1fc78fe685R16 for why I put this here. Alternatively we could copy the full NOTICE.txt here, and/or do that at package build time, but this seemed less susceptible to bit rot/human error.

FWIW, there are very few (about 4, AFAICT) packages on CRAN that have ASF source header comments, and most also have this problem (referring to a NOTICE file but no NOTICE file is in the package). Only one of those packages includes a NOTICE file (in this same location), but the context is a bit different (the package is just a vehicle for delivering the Java .jar). The most similar package to ours, sparkR (with source contained inside the spark monorepo), does not contain a NOTICE file. However, CRAN editorial review of new package submissions has increased in recent months though, and responding "but what about $PACKAGE already on CRAN with the same issue?" is a nonstarter. I mention all this just to say that there is not much of a model we can follow here.

[wesm]

Ideally NOTICE.txt would be included in the package

[nealrichardson]

Ok, done in 0cec0f1

[nealrichardson]

Current status: barring other feedback, my plan is to check out the 0.14.1 release branch locally, cherry-pick these commits onto it, and build the revised CRAN submission from that. I could just resubmit 0.14.0, but since 0.14.1 has been released already, it probably makes sense to go with that in order to pick up the Parquet timestamp fix in the C++ libraries.

Releasing 0.14.1 depends on rwinlib/arrow#2 being merged (cc @jeroen). I think autobrew/homebrew-core#1 would be nice too but is not essential.

Once CRAN has accepted the package, we can merge this patch, but we probably should not merge until then in case there is more feedback.

[nealrichardson]

0.14.1 submission was rejected with some (trivial) feedback from the CRAN humans. That was addressed in 41ca81d and 0.14.1 has been resubmitted, waiting on the next human review.

[nealrichardson]

Latest resubmission was accepted: https://cran.r-project.org/package=arrow

This is ready to merge now cc @wesm @romainfrancois

[jeroen]

👍 🎉

[wesm]

+1. Congrats everyone!

[HyukjinKwon]

This is super nice!