GH-47022: [Python] Support unsigned dictionary indices in pandas conversion #48451
+48
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HyukjinKwon
force-pushed
the
GH-48450
branch
from
0e08f57 to
531b4de
Compare
HyukjinKwon
force-pushed
the
GH-48450
branch
from
531b4de to
f18acd8
Compare
HyukjinKwon
changed the title
|
|
HyukjinKwon
force-pushed
the
GH-48450
branch
from
f18acd8 to
18ccb7e
Compare
HyukjinKwon
changed the title
|
|
3 similar comments
|
|
|
|
|
|
HyukjinKwon
force-pushed
the
GH-48450
branch
3 times, most recently
from
27a89f3 to
40f6ef1
Compare
HyukjinKwon
force-pushed
the
GH-48450
branch
from
40f6ef1 to
7e384a2
Compare
Member
Author
|
Should be ready for a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is the ticket mentioned in #7659 which implements unsigned dictionary indices in pandas conversion.
What changes are included in this PR?
Implements unsigned dictionary indices by upcasting to signed ints in pandas conversion
Are these changes tested?
Yes via:
Are there any user-facing changes?
Yes,
pd.Categorical.from_codes(indices, categories=dictionary)with unsigned integers should work now as demonstrated in the tests.