Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Dec 11, 2025

Rationale for this change

# TODO(kszucs): the names and schema arguments are not consistent with
# Table.from_array's arguments

2b36521e52 fixed the issue by:

-    return pa.RecordBatch.from_arrays(children, names=schema)
+    return pa.RecordBatch.from_arrays(children, schema=schema)

so this todo can be removed.

What changes are included in this PR?

This PR removes an obsolete todo.

Are these changes tested?

No, I removed a comment and did not test this.

Are there any user-facing changes?

No, test-only.

@github-actions github-actions bot added the awaiting review Awaiting review label Dec 11, 2025
@github-actions
Copy link

⚠️ GitHub issue #48446 has been automatically assigned in GitHub to PR creator.

@AlenkaF AlenkaF merged commit 9c247a5 into apache:main Dec 12, 2025
14 checks passed
@AlenkaF AlenkaF removed the awaiting review Awaiting review label Dec 12, 2025
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Dec 12, 2025
@HyukjinKwon
Copy link
Member Author

Thank you @AlenkaF !!!!!!

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 9c247a5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants