GH-48416: [Packaging][CI] Use custom orc_for_bundling when using FetchContent to avoid ar issues with + symbol on path #48430
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen using FetchContent to avoid ar issues with + symbol on path
|
|
github-actions
bot
added
Component: C++
awaiting committer review
raulcd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The centos-9 jobs have started failing to bundled ORC when using FetchContent due to subfolder including the
+symbol on path. This fails when bundling it withar.What changes are included in this PR?
Generate new
orc_for_bundlinglibrary not under thec++directory and add that one toARROW_BUNDLED_STATIC_LIBS. This is a similar approach we take forgrpc++Are these changes tested?
Yes, via CI
Are there any user-facing changes?
No, they shouldn't as this is just for adding it to the
libarrow_bundleddependencies