Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Dec 10, 2025

Rationale for this change

It's a millisecond variant of date array.

What changes are included in this PR?

  • Add ArrowFormat::Date64Type
  • Add ArrowFormat::Date64Array

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@github-actions
Copy link

⚠️ GitHub issue #48423 has been automatically assigned in GitHub to PR creator.

Copy link
Collaborator

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

LD_LIBRARY_PATH=/tmp/local/lib GI_TYPELIB_PATH=/tmp/local/lib/girepository-1.0 ./test/run.rb
Loaded suite test
Started
/path/to/arrow/ruby/red-arrow-format/lib/arrow-format/file-reader.rb:63: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
Finished in 0.206994416 seconds.
------------------------------------------------------------------------------------------------------------------------
15 tests, 15 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
------------------------------------------------------------------------------------------------------------------------
72.47 tests/s, 72.47 assertions/s

when Org::Apache::Arrow::Flatbuf::DateUnit::DAY
type = Date32Type.singleton
when Org::Apache::Arrow::Flatbuf::DateUnit::MILLISECOND
type = Date64Type.singleton
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need? (Cornor case)

        when Org::Apache::Arrow::Flatbuf::DateUnit::MILLISECOND
          type = Date64Type.singleton
        else
          #raise Error
        end

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it in Red FlatBuffers.

We can add #validate method to objects provided by Red FlatBuffers. It can check whether the enum value is valid or not.

@kou
Copy link
Member Author

kou commented Dec 10, 2025

@github-actions crossbow submit test-debian-ruby

@github-actions
Copy link

Revision: 523a1bc

Submitted crossbow builds: ursacomputing/crossbow @ actions-8b1529ddcb

Task Status
test-debian-ruby GitHub Actions

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Dec 10, 2025
@kou kou merged commit 6c9f542 into apache:main Dec 10, 2025
12 checks passed
@kou kou removed the awaiting changes Awaiting changes label Dec 10, 2025
@kou kou deleted the ruby-date64-array branch December 10, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants