-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-48423: [Ruby] Add support for reading date64 array #48424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
hiroyuki-sato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
LD_LIBRARY_PATH=/tmp/local/lib GI_TYPELIB_PATH=/tmp/local/lib/girepository-1.0 ./test/run.rb
Loaded suite test
Started
/path/to/arrow/ruby/red-arrow-format/lib/arrow-format/file-reader.rb:63: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
Finished in 0.206994416 seconds.
------------------------------------------------------------------------------------------------------------------------
15 tests, 15 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
------------------------------------------------------------------------------------------------------------------------
72.47 tests/s, 72.47 assertions/s
| when Org::Apache::Arrow::Flatbuf::DateUnit::DAY | ||
| type = Date32Type.singleton | ||
| when Org::Apache::Arrow::Flatbuf::DateUnit::MILLISECOND | ||
| type = Date64Type.singleton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need? (Cornor case)
when Org::Apache::Arrow::Flatbuf::DateUnit::MILLISECOND
type = Date64Type.singleton
else
#raise Error
endThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it in Red FlatBuffers.
We can add #validate method to objects provided by Red FlatBuffers. It can check whether the enum value is valid or not.
|
@github-actions crossbow submit test-debian-ruby |
|
Revision: 523a1bc Submitted crossbow builds: ursacomputing/crossbow @ actions-8b1529ddcb
|
Rationale for this change
It's a millisecond variant of date array.
What changes are included in this PR?
ArrowFormat::Date64TypeArrowFormat::Date64ArrayAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.