GH-48365: [GLib][Ruby] Add DayOfWeekOptions #48372
Merged
+231
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kou
approved these changes
Dec 5, 2025
| def test_day_of_week_function_with_week_start | ||
| omit("Missing tzdata on Windows") if Gem.win_platform? | ||
| args = [ | ||
| Arrow::ArrayDatum.new(build_timestamp_array(:milli, [1504953190000])), |
Member
There was a problem hiding this comment.
Could you add a comment the timestamp (with day of week) of 1504953190000?
Suggested change
| Arrow::ArrayDatum.new(build_timestamp_array(:milli, [1504953190000])), | |
| # 2017-09-09T10:33:10Z (Saturday) | |
| Arrow::ArrayDatum.new(build_timestamp_array(:milli, [1504953190000])), |
stenlarsson
force-pushed
the
glib-day-of-week-options
branch
from
9b60b26 to
1401e49
Compare
Contributor
Author
|
Thanks for the review @kou. Updated according to your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
DayOfWeekOptionsclass is not available in GLib/Ruby, and it is used together with theday_of_weekcompute function.What changes are included in this PR?
This adds the
DayOfWeekOptionsclass to GLib.Are these changes tested?
Yes, with Ruby unit tests.
Are there any user-facing changes?
Yes, a new class.