ARROW-5824: [Gandiva][C++] Fix decimal null literals. #4780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
praveenbingo
commented
Jul 2, 2019
praveenbingo
commented
- Type was hard coded as 0,0
- Use the input type for literals instead.
- Type was hard coded as 0,0 - Use the input type for literals instead.
Contributor
Author
|
@pravindra can you please review, CI failures look unrelated. |
pravindra
reviewed
Jul 3, 2019
| return std::make_shared<LiteralNode>(data_type, LiteralHolder((int64_t)0), true); | ||
| case arrow::Type::DECIMAL: { | ||
| DecimalScalar128 literal(0, 0); | ||
| std::shared_ptr<arrow::DecimalType> decimal_type = |
Contributor
There was a problem hiding this comment.
use checked_cast instead ?
auto decimal_type = arrow::internal::checked_pointer_cast<arrow::DecimalType>(data_type);
pravindra
approved these changes
Jul 3, 2019
Codecov Report
@@ Coverage Diff @@
## master #4780 +/- ##
==========================================
+ Coverage 87.41% 89.08% +1.66%
==========================================
Files 996 719 -277
Lines 139489 100066 -39423
Branches 1418 0 -1418
==========================================
- Hits 121938 89145 -32793
+ Misses 17189 10921 -6268
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
kou
pushed a commit
that referenced
this pull request
Jul 4, 2019
- Type was hard coded as 0,0 - Use the input type for literals instead. Author: Praveen <praveen@dremio.com> Closes #4780 from praveenbingo/ARROW-5824 and squashes the following commits: 2fa0eeb <Praveen> Address review comments. d56918c <Praveen> Fix lint issues. 41b1b0f <Praveen> ARROW-5824: Fix decimal null literals.
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
- Type was hard coded as 0,0 - Use the input type for literals instead. Author: Praveen <praveen@dremio.com> Closes #4780 from praveenbingo/ARROW-5824 and squashes the following commits: 2fa0eeb <Praveen> Address review comments. d56918c <Praveen> Fix lint issues. 41b1b0f <Praveen> ARROW-5824: Fix decimal null literals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.