Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Aug 8, 2025

Rationale for this change

We can remove a patch by updating to aws-c-common 0.12.4.

What changes are included in this PR?

Update to 0.12.4 and remove a patch.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions
Copy link

github-actions bot commented Aug 8, 2025

⚠️ GitHub issue #47291 has been automatically assigned in GitHub to PR creator.

@kou kou force-pushed the cpp-awc-c-common branch from 8db80f3 to 7bc06c9 Compare August 10, 2025 20:58
@kou
Copy link
Member Author

kou commented Aug 10, 2025

@github-actions crossbow submit -g r

@github-actions
Copy link

Revision: 7bc06c9

Submitted crossbow builds: ursacomputing/crossbow @ actions-7205a7236c

Task Status
r-binary-packages GitHub Actions
r-recheck-most GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-extra-packages GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-sanitizers GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-m1-san GitHub Actions
test-r-macos-as-cran GitHub Actions
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-release-latest Azure
test-r-rocker-r-ver-latest Azure
test-r-rstudio-r-base-4.1-focal Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions

@kou
Copy link
Member Author

kou commented Aug 12, 2025

+1

@kou kou merged commit d2b4036 into apache:main Aug 12, 2025
35 of 37 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Aug 12, 2025
@kou kou deleted the cpp-awc-c-common branch August 12, 2025 02:14
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d2b4036.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant