Skip to content

Conversation

@jonkeane
Copy link
Member

@jonkeane jonkeane commented Jul 28, 2025

Rationale for this change

We need to disable these at buildtime, so that they are also disabled on CRAN.

Resolves #47211

What changes are included in this PR?

Remove the env var set in CI, set the flag when building

Are these changes tested?

They are tests

Are there any user-facing changes?

Hopefully no!

@jonkeane jonkeane changed the title GH47211: [CI][R] Disable non-system memory allocators when on linux-devel GH-47211: [CI][R] Disable non-system memory allocators when on linux-devel Jul 28, 2025
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 28, 2025
@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-sanitizers

@github-actions
Copy link

Revision: 3b9ed4c

Submitted crossbow builds: ursacomputing/crossbow @ actions-c435dea0e6

Task Status
test-r-linux-sanitizers GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-sanitizers

@github-actions
Copy link

Revision: a988fe7

Submitted crossbow builds: ursacomputing/crossbow @ actions-e7bb96bae6

Task Status
test-r-linux-sanitizers GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-sanitizers

@github-actions
Copy link

Revision: e38b4f1

Submitted crossbow builds: ursacomputing/crossbow @ actions-1e35478af9

Task Status
test-r-linux-sanitizers GitHub Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Oh, sorry.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jul 28, 2025
@jonkeane jonkeane merged commit c3be5fc into apache:main Jul 28, 2025
35 checks passed
@jonkeane jonkeane removed the awaiting merge Awaiting merge label Jul 28, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c3be5fc.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

thisisnic pushed a commit that referenced this pull request Aug 13, 2025
…devel (#47212)

### Rationale for this change
We need to disable these at buildtime, so that they are *also* disabled on CRAN.

Resolves #47211

### What changes are included in this PR?
Remove the env var set in CI, set the flag when building

### Are these changes tested?
They are tests

### Are there any user-facing changes?
Hopefully no!

* GitHub Issue: #47211

Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI][R] Disable non-system memory allocators when on linux-devel

2 participants