-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-47211: [CI][R] Disable non-system memory allocators when on linux-devel #47212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-47211: [CI][R] Disable non-system memory allocators when on linux-devel #47212
Conversation
|
@github-actions crossbow submit test-r-linux-sanitizers |
|
Revision: 3b9ed4c Submitted crossbow builds: ursacomputing/crossbow @ actions-c435dea0e6
|
|
@github-actions crossbow submit test-r-linux-sanitizers |
|
Revision: a988fe7 Submitted crossbow builds: ursacomputing/crossbow @ actions-e7bb96bae6
|
|
@github-actions crossbow submit test-r-linux-sanitizers |
|
Revision: e38b4f1 Submitted crossbow builds: ursacomputing/crossbow @ actions-1e35478af9
|
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Oh, sorry.
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c3be5fc. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
…devel (#47212) ### Rationale for this change We need to disable these at buildtime, so that they are *also* disabled on CRAN. Resolves #47211 ### What changes are included in this PR? Remove the env var set in CI, set the flag when building ### Are these changes tested? They are tests ### Are there any user-facing changes? Hopefully no! * GitHub Issue: #47211 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Rationale for this change
We need to disable these at buildtime, so that they are also disabled on CRAN.
Resolves #47211
What changes are included in this PR?
Remove the env var set in CI, set the flag when building
Are these changes tested?
They are tests
Are there any user-facing changes?
Hopefully no!