GH-47165: [Python] Update s3 test with new non-existent bucket #47166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Python
awaiting committer review
raulcd
commented
Jul 22, 2025
Member
Author
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
This is slightly annoying but this test is about testing real aws region selection and this is specifically validating that if the bucket does not exist on that particular region it raises and Exception. I am unsure how we could block from creating a bucket.
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
Member
Author
|
As discussed with @rok and as per bucket naming convention rules this should avoid the bucket to be created while exercising the test. |
rok
approved these changes
Jul 22, 2025
Member
rok
left a comment
rok
left a comment
There was a problem hiding this comment.
Looks good. Let's merge if CI passes.
github-actions
bot
added
awaiting merge
Member
Author
|
Thanks @rok, I've merged so we fix other PRs CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Tests are failing because the bucket exists now.
What changes are included in this PR?
Update bucket name to non-existing bucket so it raises the expected exception again.
Are these changes tested?
Yes
Are there any user-facing changes?
No