GH-46974: [Integration][Archery] Add support for ARROW_JS_ROOT #46975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pitrou
reviewed
Jul 2, 2025
| ARROW_JS_ROOT = os.path.join(ARROW_BUILD_ROOT, 'js') | ||
| ARROW_JS_ROOT = os.environ.get( | ||
| 'ARROW_JS_ROOT', | ||
| os.path.join(ARROW_BUILD_ROOT, 'js') |
There was a problem hiding this comment.
Do we even need the ARROW_BUILD_ROOT fallback?
kou
force-pushed
the
archery-integration-js-root
branch
from
cc0056e to
4130e21
Compare
github-actions
bot
added
awaiting changes
kou
force-pushed
the
archery-integration-js-root
branch
from
4130e21 to
788fd97
Compare
raulcd
approved these changes
Jul 3, 2025
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2de43af. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
If we can specify the JS implementation directory by an environment variable, it's useful. Because developers don't need to copy the JS implementation to
apache/arrow/js.What changes are included in this PR?
Refer
ARROW_JS_ROOTbefore using the default JS implementation directory.Are these changes tested?
Yes.
Are there any user-facing changes?
No.