GH-46736: [CI] Disable Parquet in conan-minimum#46744
Merged
kou merged 1 commit intoapache:mainfrom Jun 9, 2025
Merged
Conversation
Member
Author
|
@github-actions crossbow submit -g conan |
|
Revision: 25cd22b Submitted crossbow builds: ursacomputing/crossbow @ actions-16c23e405a
|
Collaborator
|
LGTM👍 Thanks! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5633582. There were 66 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 16 possible false positives for unstable benchmarks that are known to sometimes produce them. |
alinaliBQ
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
Jun 17, 2025
### Rationale for this change apache#45459 introduced RapidJSON dependency to Parquet support. Conan recipe enables Parquet by default but it doesn't enable RapidJSON by default. So we can't find RapidJSON. ### What changes are included in this PR? Disable Parquet by default. We should report "Parquet support requires RapidJSON support" to Conan when we release 21.0.0. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#46736 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#45459 introduced RapidJSON dependency to Parquet support. Conan recipe enables Parquet by default but it doesn't enable RapidJSON by default. So we can't find RapidJSON.
What changes are included in this PR?
Disable Parquet by default.
We should report "Parquet support requires RapidJSON support" to Conan when we release 21.0.0.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.