Skip to content

Conversation

@WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Jun 3, 2025

Rationale for this change

This fixes an issue with the Meson configuration on Windows

What changes are included in this PR?

Fix up incorrect variable name usage

Are these changes tested?

Yes

Are there any user-facing changes?

No

@WillAyd WillAyd added the CI: Extra Run extra CI label Jun 3, 2025
@github-actions
Copy link

github-actions bot commented Jun 3, 2025

⚠️ GitHub issue #46684 has been automatically assigned in GitHub to PR creator.

@kou kou changed the title GH-46684: Fix Meson configuration issue on Windows GH-46684: [C++] Fix Meson configuration issue on Windows Jun 3, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 2aaea00 into apache:main Jun 3, 2025
38 of 42 checks passed
@kou kou removed the awaiting review Awaiting review label Jun 3, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 3, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2aaea00.

There were 73 benchmark results with an error:

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants