GH-46645: [CI][Dev][R] Use pre-commit for styler #46664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
requested review from
assignUser,
jonkeane,
raulcd and
thisisnic
as code owners
|
|
github-actions
bot
added
Component: R
awaiting committer review
jonkeane
approved these changes
Jun 2, 2025
Member
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
We should definitely still move towards air, but I'm glad to merge this now as an improvement before we reformat the world and use that.
github-actions
bot
added
awaiting merge
github-actions
bot
added
awaiting changes
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 3747a29. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We want to migrate to pre-commit from
archery lint.What changes are included in this PR?
Use pre-commit for styler against
r/.This also fixes styles of exiting files.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.