Skip to content

Conversation

@paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Jun 1, 2025

Rationale for this change

Extension arrays exported with binary view/string view storage did not export the variadic sizes buffer which resulted in crashes when reimporting.

What changes are included in this PR?

The expression that controlled whether the variadic sizes buffer was written was updated.

Are these changes tested?

Yes, a test was added

Are there any user-facing changes?

No

@github-actions
Copy link

github-actions bot commented Jun 1, 2025

⚠️ GitHub issue #46659 has been automatically assigned in GitHub to PR creator.

@paleolimbot
Copy link
Member Author

@bkietz Any chance you have a minute to ensure I understood this correctly?

Copy link
Member

@bkietz bkietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me, just a few nits

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 4, 2025
paleolimbot and others added 3 commits June 4, 2025 14:46
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
@paleolimbot
Copy link
Member Author

Thank you for the review!

@paleolimbot paleolimbot merged commit 610c201 into apache:main Jun 4, 2025
39 of 43 checks passed
@paleolimbot paleolimbot removed the awaiting merge Awaiting merge label Jun 4, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 610c201.

There were 70 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants