Skip to content

Conversation

@amoeba
Copy link
Member

@amoeba amoeba commented May 30, 2025

Rationale for this change

Resolves #46642.

What changes are included in this PR?

  • Updated columnar format doc

Are these changes tested?

Yes, rendered locally.

Are there any user-facing changes?

No.

@amoeba amoeba requested a review from felipecrv May 30, 2025 03:02
@amoeba amoeba requested review from kou and pitrou May 30, 2025 03:04
@amoeba amoeba changed the title GH-46642: [Format] Add footnote GH-46642: [Format] Add footnote clarifying REE layout has O(log n) random access May 30, 2025
@amoeba
Copy link
Member Author

amoeba commented May 30, 2025

For reviewers: I tried to keep it short though I think there are other ways we might address this such as changing the bullet to something like "Generally O(1) (constant-time) random access". Feel free to suggest a different direction.

@kou
Copy link
Member

kou commented May 30, 2025

@github-actions crossbow submit preview-docs

@github-actions
Copy link

Revision: ed91ace

Submitted crossbow builds: ursacomputing/crossbow @ actions-39b42b1501

Task Status
preview-docs GitHub Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 30, 2025
@amoeba amoeba merged commit 53b4af4 into apache:main Jun 2, 2025
8 of 10 checks passed
@amoeba amoeba removed the awaiting merge Awaiting merge label Jun 2, 2025
@amoeba
Copy link
Member Author

amoeba commented Jun 2, 2025

Merged. Thanks for the quick reviews all.

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 53b4af4.

There were 65 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Format] Clarify that the REE layout has O(log n) random access

4 participants