-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-46613: [GLib] Add GArrowBaseListDataType #46615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Could you use this as the parent class of |
|
@kou Thank you for your review you meant the following. correct? If so, fixed -G_DECLARE_DERIVABLE_TYPE(
- GArrowListDataType, garrow_list_data_type, GARROW, LIST_DATA_TYPE, GArrowDataType)
+G_DECLARE_DERIVABLE_TYPE(GArrowListDataType,
+ garrow_list_data_type,
+ GARROW,
+ LIST_DATA_TYPE,
+ GArrowBaseListDataType) |
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
|
Thanks! All suggested change applied. |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5890232. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
GLib should be able to use
arrow::BaseListType.What changes are included in this PR?
Add
GArrowBaseListDataTypeand use it as a base class ofGArrowListDataType.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.