Skip to content

GH-46513: [Archery] Add external library support in Archery #46530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Alex-PLACET
Copy link

@Alex-PLACET Alex-PLACET commented May 21, 2025

Rationale for this change

Address #46513:
Add the possibility to use a library which is not part of the "official" implementations, in the integration tests

What changes are included in this PR?

Add new options in the CLI to be able to define the path to a library to test, and it's compatibility with the tests (IPC producer/consumer, c data array/schema impoter/exporter).
Add tester_external_library.py
Modify runner.py to use ExternalLibraryTester

Are these changes tested?

Yes localy

Are there any user-facing changes?

Yes, new options in the CLI and environment variable supported.
there is no breaking change.

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@Alex-PLACET Alex-PLACET changed the title Add external library support in Archery [GH-46513]:Add external library support in Archery May 21, 2025
@github-actions github-actions bot added the awaiting review Awaiting review label May 21, 2025
@Alex-PLACET Alex-PLACET changed the title [GH-46513]:Add external library support in Archery GH-46513: [Archery] Add external library support in Archery May 21, 2025
Copy link

⚠️ GitHub issue #46513 has been automatically assigned in GitHub to PR creator.

@@ -108,3 +108,4 @@ java/.mvn/.develocity/
# rat
filtered_rat.txt
rat.txt
build
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

@@ -17,6 +17,7 @@

from collections import namedtuple
from io import StringIO
from typing import Optional
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant