-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-46513: [Archery] Add external library support in Archery #46530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
GH-46513: [Archery] Add external library support in Archery #46530
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
See also: |
|
@@ -108,3 +108,4 @@ java/.mvn/.develocity/ | |||
# rat | |||
filtered_rat.txt | |||
rat.txt | |||
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to remove
@@ -17,6 +17,7 @@ | |||
|
|||
from collections import namedtuple | |||
from io import StringIO | |||
from typing import Optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To remove
Rationale for this change
Address #46513:
Add the possibility to use a library which is not part of the "official" implementations, in the integration tests
What changes are included in this PR?
Add new options in the CLI to be able to define the path to a library to test, and it's compatibility with the tests (IPC producer/consumer, c data array/schema impoter/exporter).
Add tester_external_library.py
Modify runner.py to use ExternalLibraryTester
Are these changes tested?
Yes localy
Are there any user-facing changes?
Yes, new options in the CLI and environment variable supported.
there is no breaking change.