Skip to content

GH-46499: [CI][Crossbow][C++] Use apache/arrow for Meson #46501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kou
Copy link
Member

@kou kou commented May 19, 2025

Rationale for this change

We're using Crossbow to offload CI jobs to separated repository but it has some inconveniences. See #46014 for details.

What changes are included in this PR?

Use CI: Extra label to run Meson CI job as an extra CI job.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou kou added the CI: Extra Run extra CI label May 19, 2025
Copy link

⚠️ GitHub issue #46499 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 19, 2025
@kou kou force-pushed the ci-crossbow-cpp-meson branch from 36044ff to db197ec Compare May 19, 2025 09:14
@kou kou added CI: Extra Run extra CI and removed CI: Extra Run extra CI labels May 19, 2025
@kou kou force-pushed the ci-crossbow-cpp-meson branch from db197ec to 2d21358 Compare May 19, 2025 09:16
@kou kou added CI: Extra Run extra CI and removed CI: Extra Run extra CI labels May 19, 2025
@kou
Copy link
Member Author

kou commented May 19, 2025

pull_request.types: [labeled] will not work well. We need another approach.

@kou kou force-pushed the ci-crossbow-cpp-meson branch 2 times, most recently from cd9d8d8 to b036227 Compare May 20, 2025 05:58
@kou kou removed the CI: Extra Run extra CI label May 20, 2025
@kou kou force-pushed the ci-crossbow-cpp-meson branch 2 times, most recently from c8212e4 to f55a515 Compare May 20, 2025 06:03
@kou kou added the CI: Extra Run extra CI label May 20, 2025
@kou kou force-pushed the ci-crossbow-cpp-meson branch 2 times, most recently from 24717c1 to c3a2f66 Compare May 20, 2025 06:16
needs: check-labels
name: ${{ matrix.title }}
runs-on: ${{ matrix.runs-on }}
if: needs.check-labels.outputs.ci-extra == 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a separate job would it work to check for the desired label here? Something like https://stackoverflow.com/a/62331521

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You referred types: [labeled] approach, right?
It works only when CI: Extra label is added. It doesn't work when we push more commits after we add CI: Extra label.

https://stackoverflow.com/a/74829754 will work for the case too but we want to reuse this for nightly builds (github.event_name == 'workflow_dispatch') too.
FYI: We're running dev/tasks/tasks.yml jobs nightly: https://lists.apache.org/list.html?builds@arrow.apache.org

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels May 20, 2025
@kou kou force-pushed the ci-crossbow-cpp-meson branch from c3a2f66 to 15f4a51 Compare May 22, 2025 03:21
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting change review Awaiting change review CI: Extra Run extra CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants