-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-46499: [CI][Crossbow][C++] Use apache/arrow for Meson #46501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
36044ff
to
db197ec
Compare
db197ec
to
2d21358
Compare
|
cd9d8d8
to
b036227
Compare
c8212e4
to
f55a515
Compare
24717c1
to
c3a2f66
Compare
needs: check-labels | ||
name: ${{ matrix.title }} | ||
runs-on: ${{ matrix.runs-on }} | ||
if: needs.check-labels.outputs.ci-extra == 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of a separate job would it work to check for the desired label here? Something like https://stackoverflow.com/a/62331521
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You referred types: [labeled]
approach, right?
It works only when CI: Extra
label is added. It doesn't work when we push more commits after we add CI: Extra
label.
https://stackoverflow.com/a/74829754 will work for the case too but we want to reuse this for nightly builds (github.event_name == 'workflow_dispatch'
) too.
FYI: We're running dev/tasks/tasks.yml
jobs nightly: https://lists.apache.org/list.html?builds@arrow.apache.org
c3a2f66
to
15f4a51
Compare
Rationale for this change
We're using Crossbow to offload CI jobs to separated repository but it has some inconveniences. See #46014 for details.
What changes are included in this PR?
Use
CI: Extra
label to run Meson CI job as an extra CI job.Are these changes tested?
Yes.
Are there any user-facing changes?
No.