GH-46367: [C++] Prevent Meson from using git info if built as subproject #46368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
@bgilbert this should solve your feedback from mesonbuild/wrapdb#2099 (comment) in the Arrow repo. Please let me know if you had something else in mind |
Contributor
Author
|
@github-actions crossbow submit *meson |
|
Revision: 1a508dd Submitted crossbow builds: ursacomputing/crossbow @ actions-433d562cb8
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0c90264. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When used as a subproject, the Arrow Meson configuration may end up pulling git version information from the main project
What changes are included in this PR?
This prevents Meson from gathering git information when Arrow is built as a subproject
Are these changes tested?
Yes
Are there any user-facing changes?
No