GH-45254: [C++][Acero] Fix the row offset truncation in row table merge #45255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pitrou , will you take a look? |
zanmato1984
commented
Jan 14, 2025
| constexpr int value_no_match_length_min = 128; | ||
| constexpr int value_no_match_length_max = 129; | ||
| constexpr int value_match_length = 130; | ||
| // The value "DDD..." will be hashed to the partition over 4GB of the hash table. |
There was a problem hiding this comment.
Note this really depends on the hash algorithm which is opaque, but this as well is the best I can do so far.
github-actions
bot
added
awaiting committer review
pitrou
approved these changes
Jan 14, 2025
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ea47172. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #45254
What changes are included in this PR?
First modify the test case to expose the suspecting bug.
Then the fix in source.
Are these changes tested?
By existing tests.
Are there any user-facing changes?
None.