Skip to content

Conversation

@danking
Copy link
Contributor

@danking danking commented Jan 10, 2025

Rationale for this change

replace_with_mask should link to the section containing it.

What changes are included in this PR?

replace_with_mask links to the section containing it.

Are these changes tested?

No.

Are there any user-facing changes?

Yes, but only in the docs. No code is changed.

It previously linked to the structural transforms (the section before the section containing `replace_with_mask`).
@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@danking danking changed the title fix: replace_with_mask links to replace functions MINOR: [Docs] replace_with_mask links to replace functions Jan 10, 2025
@kou kou changed the title MINOR: [Docs] replace_with_mask links to replace functions MINOR: [Docs][C++] replace_with_mask links to replace functions Jan 11, 2025
@kou
Copy link
Member

kou commented Jan 11, 2025

@github-actions crossbow submit preview-docs

@github-actions
Copy link

Revision: 9292a88

Submitted crossbow builds: ursacomputing/crossbow @ actions-4ef5db9166

Task Status
preview-docs GitHub Actions

@pitrou
Copy link
Member

pitrou commented Jan 13, 2025

The problem is that the replace-functions reference does not seem to exist. You can see that no link is generated here: http://crossbow.voltrondata.com/pr_docs/45223/cpp/compute.html

@danking
Copy link
Contributor Author

danking commented Jan 13, 2025

Huh. I guess Sphinx/rST/??? gives sections ids in HTML but doesn't expose that to rST. I've added a label following the naming scheme of the structural transforms one.

@danking
Copy link
Contributor Author

danking commented Jan 13, 2025

@github-actions crossbow submit preview-docs

@github-actions
Copy link

Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/12756883458

@kou
Copy link
Member

kou commented Jan 13, 2025

@github-actions crossbow submit preview-docs

@github-actions
Copy link

Revision: aaf0d24

Submitted crossbow builds: ursacomputing/crossbow @ actions-63bfc892bc

Task Status
preview-docs GitHub Actions

@danking
Copy link
Contributor Author

danking commented Jan 14, 2025

Docs now look good. Not sure what’s up with the 500s. Transient maybe?

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Yes. They are unrelated.

@kou kou merged commit 8f47394 into apache:main Jan 14, 2025
2 of 6 checks passed
@kou kou removed the awaiting review Awaiting review label Jan 14, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8f47394.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants