-
Couldn't load subscription status.
- Fork 3.9k
MINOR: [Docs][C++] replace_with_mask links to replace functions #45223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It previously linked to the structural transforms (the section before the section containing `replace_with_mask`).
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
|
@github-actions crossbow submit preview-docs |
|
Revision: 9292a88 Submitted crossbow builds: ursacomputing/crossbow @ actions-4ef5db9166
|
|
The problem is that the |
|
Huh. I guess Sphinx/rST/??? gives sections ids in HTML but doesn't expose that to rST. I've added a label following the naming scheme of the structural transforms one. |
|
@github-actions crossbow submit preview-docs |
|
|
@github-actions crossbow submit preview-docs |
|
Revision: aaf0d24 Submitted crossbow builds: ursacomputing/crossbow @ actions-63bfc892bc
|
|
Docs now look good. Not sure what’s up with the 500s. Transient maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Yes. They are unrelated.
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8f47394. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
replace_with_maskshould link to the section containing it.What changes are included in this PR?
replace_with_masklinks to the section containing it.Are these changes tested?
No.
Are there any user-facing changes?
Yes, but only in the docs. No code is changed.