Skip to content

Conversation

@zanmato1984
Copy link
Contributor

Rationale for this change

A piece of comment is wrongly introduced in #43389.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@zanmato1984
Copy link
Contributor Author

cc @kou @pitrou

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Dec 25, 2024
@zanmato1984 zanmato1984 merged commit 0a00e25 into apache:main Dec 25, 2024
37 of 38 checks passed
@zanmato1984 zanmato1984 removed the awaiting merge Awaiting merge label Dec 25, 2024
@zanmato1984 zanmato1984 deleted the fix-swiss-join-avx2-comment branch December 25, 2024 06:33
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0a00e25.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants