GH-45048: [C++][Parquet] Deprecate unused chunk_size parameter in parquet::arrow::FileWriter::NewRowGroup()
#45088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Parquet
Component: C++
Component: Python
Component: GLib
awaiting committer review
kszucs
commented
Dec 20, 2024
github-actions
bot
added
awaiting changes
kszucs
commented
Dec 20, 2024
github-actions
bot
added
awaiting merge
|
Can we move forward to merge this? |
…e review Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
raulcd
reviewed
Jan 15, 2025
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d7dc586. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Just noticed that the implementation doesn't use the parameter.
What changes are included in this PR?
Remove the parameter from
NewRowGroup()Are these changes tested?
Are there any user-facing changes?
The
chunk_sizeparameter is now deprecated.chunk_sizeparameter inparquet::arrow::FileWriter::NewRowGroup()#45048