Skip to content

GH-44742: [Ruby] Fix a bug that empty struct list value can't be built #44763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Nov 19, 2024
Merged

GH-44742: [Ruby] Fix a bug that empty struct list value can't be built #44763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ruby/red-arrow/lib/arrow/list-array-builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def append_value(*args)
when nil
append_null
when ::Array
return if value.empty?
append_value_raw
@value_builder ||= value_builder
@value_builder.append(*value)
Expand Down
9 changes: 9 additions & 0 deletions ruby/red-arrow/test/test-list-array-builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,15 @@ def setup
array = @builder.finish
assert_equal([true, false, true], array[0].to_a)
end

test("Struct[]") do
item_type = Arrow::StructDataType.new([{name: "visible", type: :boolean}])
data_type = Arrow::ListDataType.new(name: "struct", data_type: item_type)
builder = Arrow::ListArrayBuilder.new(data_type)
builder.append_value([])
array = builder.finish
assert_equal([], array[0].to_a)
end
end

sub_test_case("#append_values") do
Expand Down
Loading