GH-44754: [C++] Use lowercased windows.h to enable cross-platform builds
#44755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kou
approved these changes
Nov 17, 2024
Member
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
Could you use our pull request template next time?
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 23328ff. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
<Windows.h>doesn't work cross-compiling to Windows with case-sensitive file system.What changes are included in this PR?
Use lowercase.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.