Skip to content

Conversation

@c8ef
Copy link
Contributor

@c8ef c8ef commented Nov 16, 2024

Rationale for this change

There is a minor typo in the test case.

What changes are included in this PR?

Fix the simple typo in the test.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou kou changed the title MINOR: [C++] Fix the simple typo in the test. MINOR: [C++] Fix the simple typo in the test Nov 17, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 99bdb80 into apache:main Nov 18, 2024
39 checks passed
@kou kou removed the awaiting review Awaiting review label Nov 18, 2024
@c8ef c8ef deleted the patch-1 branch November 18, 2024 01:16
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 99bdb80.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants