-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-44734: [C++][CI] Fix arrow-c-bridge-test timeout with threading disabled #44737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
@github-actions crossbow submit -g cpp |
|
Revision: 64bc000 Submitted crossbow builds: ursacomputing/crossbow @ actions-6635482d34 |
cpp/src/arrow/c/bridge_test.cc
Outdated
| }); | ||
| } | ||
|
|
||
| #ifdef ARROW_ENABLE_THREADING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead skip in the SetUp method of the test class below?
|
@github-actions crossbow submit -g cpp |
|
Revision: 26d5813 Submitted crossbow builds: ursacomputing/crossbow @ actions-31c2edbae5 |
|
@github-actions crossbow submit -g cpp |
|
Revision: 32cb80b Submitted crossbow builds: ursacomputing/crossbow @ actions-fe93653fee |
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @zeroshade !
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 4dc0492. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
The Async C Device Stream Interface unit tests requiring threading to be enabled, but a couple of our CI runs go with ARROW_ENABLE_THREADING disabled.
What changes are included in this PR?
The Async C Device Stream interface tests are guarded with
#ifdef ARROW_ENABLE_THREADINGto prevent CI timeouts.