Skip to content

Conversation

@amoeba
Copy link
Member

@amoeba amoeba commented Nov 13, 2024

Rationale for this change

If you set ARROW_TMPDIR and run TEST_DEFAULT=0 TEST_INTEGRATION=1 dev/release/verify-release-candidate.sh repeatedly, you'll run into an error:

mv: rename /Users/bryce/src/apache/arrow/arrow-tempdir//java-jni-install/lib/arrow_cdata_jni to /Users/bryce/src/apache/arrow/arrow-tempdir//java-jni-dist/arrow_cdata_jni: Directory not empty

What changes are included in this PR?

In the test_package_java step in the verification script, I added a rm -fr to get rid of java-jni-dist dir so the following mv command works.

Are these changes tested?

Yes, locally.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the awaiting review Awaiting review label Nov 13, 2024
@amoeba
Copy link
Member Author

amoeba commented Nov 13, 2024

Reviewers feel free to suggest a safer alternative than rm -fr. I think it's safe here but happy to take feedback on it.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 354a22f into apache:main Nov 14, 2024
6 checks passed
@kou kou removed the awaiting review Awaiting review label Nov 14, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 14, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 354a22f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants