Skip to content

Conversation

@amoeba
Copy link
Member

@amoeba amoeba commented Nov 13, 2024

Rationale for this change

#44716

What changes are included in this PR?

Added numpy to the integration group in archery's setup.py.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #44716 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Nov 13, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 479e350 into apache:main Nov 14, 2024
8 checks passed
@kou kou removed the awaiting review Awaiting review label Nov 14, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 14, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 479e350.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants