Skip to content

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented Nov 12, 2024

Rationale for this change

Currently from_buffers is not working with StringView on Python because we validate against num_buffers. This only take into account the mandatory buffers but does not take into account the variadic_spec that can be present for both string_view and binary_view

What changes are included in this PR?

Take into account whether the type contains a variadic_spec for the non-mandatory buffers and only check lower_bound number of buffers.

Are these changes tested?

Yes, I've added a couple of tests.

Are there any user-facing changes?

We are exposing a new method on the Python DataType. has_variadic_buffers which tells us whether the number of buffers expected is only lower-bounded by num_buffers.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Nov 12, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Nov 12, 2024
@raulcd raulcd added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Nov 12, 2024
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Nov 12, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Nov 13, 2024
@raulcd raulcd added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Nov 14, 2024
Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be merging this as it was approved with a single minor comment about the error message formatting which has been updated

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Nov 18, 2024
@raulcd raulcd merged commit aa26f28 into apache:main Nov 18, 2024
14 checks passed
@raulcd raulcd removed the awaiting changes Awaiting changes label Nov 18, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit aa26f28.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 27 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants