Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Nov 11, 2024

Rationale for this change

Go, Rust -> C++, Java, C# don't exist.

What changes are included in this PR?

Add Go, Rust -> C++, Java, C# pairs.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #44479 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Nov 11, 2024
@kou
Copy link
Member Author

kou commented Nov 11, 2024

https://github.com/apache/arrow/actions/runs/11775797590/job/32796921021?pr=44691#step:10:13686

Integration: Test: Flight: C++ -> C++
Integration: Test: Flight: C++ -> Java
Integration: Test: Flight: C++ -> C#
Integration: Test: Flight: Java -> C++
Integration: Test: Flight: Java -> Java
Integration: Test: Flight: Java -> C#
Integration: Test: Flight: C# -> C++
Integration: Test: Flight: C# -> Java
Integration: Test: Flight: C# -> C#
Integration: Test: Flight: C++ -> Go
Integration: Test: Flight: C++ -> Rust
Integration: Test: Flight: Java -> Go
Integration: Test: Flight: Java -> Rust
Integration: Test: Flight: C# -> Go
Integration: Test: Flight: C# -> Rust
Integration: Test: Flight: Go -> C++
Integration: Test: Flight: Go -> Java
Integration: Test: Flight: Go -> C#
Integration: Test: Flight: Rust -> C++
Integration: Test: Flight: Rust -> Java
Integration: Test: Flight: Rust -> C#
  • C++, Java , C# <-> C++, Java, C#: All pairs exist: OK
  • C++, Java, C# -> Go, Rust: All pairs exist: OK
  • Go, Rust -> C++, Java, C#: All pairs exist: OK
  • Go, Rust <-> Go, Rust: No pairs exist: OK

@kou
Copy link
Member Author

kou commented Nov 14, 2024

+1

@kou kou merged commit 65f498b into apache:main Nov 14, 2024
@kou kou deleted the ci-integration-flight-missing-patterns branch November 14, 2024 05:54
@kou kou removed the awaiting committer review Awaiting committer review label Nov 14, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 65f498b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant