Skip to content

GH-43808: [C++] skip -0117 in StrptimeZoneOffset for old glibc #44621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 3 commits into from
Nov 15, 2024
Merged

GH-43808: [C++] skip -0117 in StrptimeZoneOffset for old glibc #44621

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a63821
[C++] skip `-0117` in StrptimeZoneOffset for old glibc
h-vetinari Nov 2, 2024
eb3e551
reshuffle to appease linter
h-vetinari Nov 11, 2024
798152b
Fix condition
kou Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions cpp/src/arrow/util/value_parsing_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,12 +838,25 @@ TEST(TimestampParser, StrptimeZoneOffset) {
std::string format = "%Y-%d-%m %H:%M:%S%z";
auto parser = TimestampParser::MakeStrptime(format);

std::vector<std::string> values = {
"2018-01-01 00:00:00+0000",
"2018-01-01 00:00:00+0100",
#if defined(__GLIBC__) && defined(__GLIBC_MINOR__)
// glibc < 2.28 doesn't support "-0117" timezone offset.
// See also: https://github.com/apache/arrow/issues/43808
# if ((__GLIBC__ == 2) && (__GLIBC_MINOR__ >= 28)) || (__GLIBC__ >= 3)
"2018-01-01 00:00:00-0117",
# endif
#else
"2018-01-01 00:00:00-0117",
#endif
"2018-01-01 00:00:00+0130"
};

// N.B. GNU %z supports ISO8601 format while BSD %z supports only
// +HHMM or -HHMM and POSIX doesn't appear to define %z at all
for (auto unit : TimeUnit::values()) {
for (const std::string value :
{"2018-01-01 00:00:00+0000", "2018-01-01 00:00:00+0100",
"2018-01-01 00:00:00+0130", "2018-01-01 00:00:00-0117"}) {
for (const std::string& value : values) {
SCOPED_TRACE(value);
int64_t converted = 0;
int64_t expected = 0;
Expand Down