-
Notifications
You must be signed in to change notification settings - Fork 3.9k
ARROW-341: [Python] Move pyarrow's C++ code to the main C++ source tree, install libarrow_python and headers #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
One downside to this change is that the C++ libraries are now dependent on the Python interpreter version (see corresponding changes for Travis CI), similar to Boost.Python. I think the benefits outweigh the downsides, though. |
|
@wesm This definitely breaks the |
|
This branch is stable -- I think you can go ahead with the fixes. I made best efforts to treat arrow_python like you are treating the rest of the library stack |
Change-Id: Ia7c31d5c7cbc7de5b6ad65e53120918ddeba2db9
Change-Id: I291f4749c387e58a947b7df4c55f18de3c576d03
Change-Id: I912c8adaaef524b261e46d613e57e246ee4a5dce
Change-Id: Ia2fbe244330dfa2d301571f48423afb37d701429
Change-Id: I9066fe7688f18aed9b72ce84004f5df957585ecb
Change-Id: Ib453bee026ef0601a510eab7d2d334341310927c
Change-Id: Idb61c009888e168c8b3bcf704a1a201b81d43a6b
Change-Id: I3421335a578400a40bd392fc9b290cf63f9b3893
Change-Id: Ifbc0262b0f8cd83c8c9f6cf56ca9f7fb7eae0e3f
… library on OS X Change-Id: I8a909c0f59dbe9cc0991c6826306608598b15d67
|
Rebased |
|
@xhochy the manylinux1 build is broken because of the multiarch changes f5157a0 This will have to get fixed in FindArrow.cmake in Parquet. |
|
Suggest we merge this as is and fix up the build toolchain for manylinux1 in subsequent patches (I am happy to help, installed docker and just tried running the docker build) |
|
Ok, then let's continue first on the |
xhochy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
|
Cool, merging, thank you |
…pache#440) Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.18.1 to 2.18.2. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This will enable third parties to link to
libarrow_python.For now, the pyarrow build system continues to use CMake -- for the purpose of resolving the thirdparty toolchain we may or may not want to go completely to distutils, but we can sort that out later.