Skip to content

Conversation

@wesm
Copy link
Member

@wesm wesm commented Mar 25, 2017

This will enable third parties to link to libarrow_python.

For now, the pyarrow build system continues to use CMake -- for the purpose of resolving the thirdparty toolchain we may or may not want to go completely to distutils, but we can sort that out later.

@wesm
Copy link
Member Author

wesm commented Mar 25, 2017

One downside to this change is that the C++ libraries are now dependent on the Python interpreter version (see corresponding changes for Travis CI), similar to Boost.Python. I think the benefits outweigh the downsides, though.

@xhochy
Copy link
Member

xhochy commented Mar 26, 2017

@wesm This definitely breaks the manylinux1 packages. Once this branch has a stable state, I would like to PR into this branch to get them working again. I'm a bit reluctant to add this to Travis as it would extend our build times even further.

@wesm
Copy link
Member Author

wesm commented Mar 26, 2017

This branch is stable -- I think you can go ahead with the fixes. I made best efforts to treat arrow_python like you are treating the rest of the library stack

wesm added 10 commits March 26, 2017 11:02
Change-Id: Ia7c31d5c7cbc7de5b6ad65e53120918ddeba2db9
Change-Id: I291f4749c387e58a947b7df4c55f18de3c576d03
Change-Id: I912c8adaaef524b261e46d613e57e246ee4a5dce
Change-Id: Ia2fbe244330dfa2d301571f48423afb37d701429
Change-Id: I9066fe7688f18aed9b72ce84004f5df957585ecb
Change-Id: Ib453bee026ef0601a510eab7d2d334341310927c
Change-Id: Idb61c009888e168c8b3bcf704a1a201b81d43a6b
Change-Id: I3421335a578400a40bd392fc9b290cf63f9b3893
Change-Id: Ifbc0262b0f8cd83c8c9f6cf56ca9f7fb7eae0e3f
… library on OS X

Change-Id: I8a909c0f59dbe9cc0991c6826306608598b15d67
@wesm
Copy link
Member Author

wesm commented Mar 26, 2017

Rebased

@wesm
Copy link
Member Author

wesm commented Mar 26, 2017

@xhochy the manylinux1 build is broken because of the multiarch changes f5157a0

-- Found the Arrow core library: /arrow-dist/lib64/libarrow.so
-- Found the Arrow IO library: /arrow-dist/lib64/libarrow_io.so
<SNIP>
make[2]: *** No rule to make target `/arrow-dist/lib/libarrow.so', needed by `build/release/libparquet.so'.  Stop.

This will have to get fixed in FindArrow.cmake in Parquet.

@wesm
Copy link
Member Author

wesm commented Mar 26, 2017

Suggest we merge this as is and fix up the build toolchain for manylinux1 in subsequent patches (I am happy to help, installed docker and just tried running the docker build)

@xhochy
Copy link
Member

xhochy commented Mar 26, 2017

Ok, then let's continue first on the parquet-cpp side.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@wesm
Copy link
Member Author

wesm commented Mar 26, 2017

Cool, merging, thank you

@asfgit asfgit closed this in 3aac4ad Mar 26, 2017
@wesm wesm deleted the ARROW-341 branch March 26, 2017 15:50
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…pache#440)

Bumps
[com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom)
from 2.18.1 to 2.18.2.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants